Sema: replace legacy Copyable containment check (NCGenerics XFAILs) #72240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
|
preset=ncgenerics,smoketest=macosx |
We can use part of the new infrastructure if we simply handle abstract conformances to Copyable, which is what we'd get upon lookup for a nominal in the old world. This means that we can merge diagnostics for the containment test together, and fix differences with deinit diagnostics.
kavon
force-pushed
the
ncgenerics-xfails-1
branch
from
fda9a35 to
01864d9
Compare
|
@swift-ci smoke test |
|
preset=ncgenerics,smoketest=macosx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use part of the new infrastructure if we simply handle abstract conformances to Copyable, which is what we'd get upon lookup for a nominal in the old world. This means that we can merge diagnostics for the containment test together, and fix differences with deinit diagnostics.